KNOX-3017 - Avoid showing lifetime adjustment popup when TTL is set to -1 #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Two changes on the
Token Generation UI:homepagetopology is configured withUnlimited token lifetime, the lifetime adjustment popup will not shown. The logic was there before, this was a casting issue between strings and numbers in the JS code.exclamationicon to better emphasize theUnlimited lifetimesetting on the UI.How was this patch tested?
Manually tested and confirmed that the popup is no longer displayed when creating a 1-year token with
Unlimited lifetimesettings. The new exclamation mark is shown as expected (tested with and without the-1TTL).